feat: snippets for table (under tree dots in navigation tree) #1476
Conversation
astandrik
force-pushed
the
astandrik.snippets-for-table-1299
branch
from
5e7367f to
c198207
Compare
| { | ||
| paths, | ||
| database, | ||
| timeout, |
There was a problem hiding this comment.
I think you should exclude timeout (and probably concurrentId) in serializeQueryArgs, otherwise your getTableSchemaData will always initiate a new request and will never reuse data from other request to overviewApi
There was a problem hiding this comment.
In current versions there is always a new request, even if entity overview have already been loaded
There was a problem hiding this comment.
removed timeout and concurrentId
now queries use same api and timeout moved to front with Promise.race and wait
| paths: [path], | ||
| database: tenantName, | ||
| timeout: TABLE_SCHEMA_TIMEOUT, | ||
| concurrentId: getTableSchemaDataConcurrentId + 'getOverview', |
There was a problem hiding this comment.
Why do you need concurrentId here?
| getTableSchemaData: build.mutation<SchemaData[], GetTableSchemaDataParams>({ | ||
| queryFn: async ({path, tenantName, type}, {dispatch}) => { | ||
| try { | ||
| const schemaData = await dispatch( |
There was a problem hiding this comment.
Do you really need this request for view? Probably, you should check if it's a table here
if (isViewType(type)){
// do request for a view
} else {
// do request for a table
}
|
We use tableSchemaDataApi as a distinct mutation that is declared in SchemaTree so that we can get IsLoading parameter (in the next task) that will show loading state in the button (after some work in NavigationTree component) |
Closes #1299
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Bundle Size: 🔺
Current: 78.94 MB | Main: 78.94 MB
Diff: +0.01 MB (0.01%)
ℹ️ CI Information